-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use npm package imports, update highlightjs #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some issues upstream, will change them before this is ready to merge.
@sgoudham this is now ready for review, upstream has been fixed with catppuccin/highlightjs@b4458e9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I'm clear on the build process now, you'd be running something like npm build
(my memory fails me but I think that's the task) and then cargo build --release
?
Yeah, |
Do you want me to give this a shot? It would involve adding an NPM build step to the CI. I'm also happy to take on #2. |
I'd really appreciate that @nekowinston, I really haven't the time for this so it would mean a lot ❤️ |
This PR changes the build process to use the
@catppuccin/palette
and@catppuccin/highlightjs
NPM packages.I've also addedbin/
to the.gitignore
since it seems auto-generated.Turns out I've built it to the wrong directory before, should be fixed with 912f1ba